Fix inconsistent final plan when labels are added to resources (Googl…

…eCloudPlatform#7923)
shourya116 · May 25, 2023 · 366f653 · 366f653
1 parent b065487
commit 366f653
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/mmv1/third_party/terraform/resources/resource_dataflow_job.go.erb b/mmv1/third_party/terraform/resources/resource_dataflow_job.go.erb
@@ -120,6 +120,7 @@ func ResourceDataflowJob() *schema.Resource {
 			"labels": {
 				Type:             schema.TypeMap,
 				Optional:         true,
+				Computed:         true,
 				DiffSuppressFunc: resourceDataflowJobLabelDiffSuppress,
 				Description:      `User labels to be specified for the job. Keys and values should follow the restrictions specified in the labeling restrictions page. NOTE: Google-provided Dataflow templates often provide default labels that begin with goog-dataflow-provided. Unless explicitly set in config, these labels will be ignored to prevent diffs on re-apply.`,
 			},

diff --git a/mmv1/third_party/terraform/resources/resource_storage_bucket.go.erb b/mmv1/third_party/terraform/resources/resource_storage_bucket.go.erb
@@ -85,6 +85,7 @@ func ResourceStorageBucket() *schema.Resource {
 			"labels": {
 				Type:        schema.TypeMap,
 				Optional:    true,
+				Computed:    true,
 				// GCP (Dataplex) automatically adds labels
 				DiffSuppressFunc: resourceDataplexLabelDiffSuppress,
 				Elem:        &schema.Schema{Type: schema.TypeString},