Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve source error message #138

Merged
merged 6 commits into from
Aug 5, 2024
Merged

Conversation

shouya
Copy link
Owner

@shouya shouya commented Aug 5, 2024

Previously, if an endpoint failed to fetch the source, the endpoint would respond with a status 500 and an error message too specific. For example, it could be a "500: bad url" which is not very clear to the user that it's the source url that's broken or an url elsewhere.

This commit improves on the error message by providing a more user-friendly message:

  • http request errors from anywhere in the pipeline will show as a 502 error with the failed status code and the requesting url is returned in the error message
  • source errors will indicate it's a source error

@shouya shouya force-pushed the improve-source-error-message branch from 82bdb59 to bfa95c6 Compare August 5, 2024 07:20
@shouya shouya merged commit 9104cdf into master Aug 5, 2024
2 checks passed
@shouya shouya deleted the improve-source-error-message branch August 5, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant