Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow unspecified filters key #141

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Conversation

shouya
Copy link
Owner

@shouya shouya commented Aug 6, 2024

Previously the filters key is required for an endpoint definition. Now we have cases where the filters are no longer needed:

  • endpoints with on-the-fly filters
  • endpoints merely meant to proxy upstream feeds (for example, with templated source)

In such cases, we should allow the user to omit the unncessary filters key altogether.

@shouya shouya changed the title fix: allow unspecified filters key fix: Allow unspecified filters key Aug 6, 2024
@shouya shouya merged commit f05b2a3 into master Aug 6, 2024
2 checks passed
@shouya shouya deleted the make-filters-key-optional branch August 6, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant