fix: improve text/xml and application/xml content type handling #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shouya
force-pushed
the
fix-content-type-handling
branch
from
2186377
to
c4230a3
Compare
shouya
force-pushed
the
fix-content-type-handling
branch
from
c4230a3
to
a75b377
Compare
This reverts commit eaf0596.
shouya
force-pushed
the
fix-content-type-handling
branch
from
a75b377
to
3d942e8
Compare
This reverts commit 817c68c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
text/xmlandapplication/xmlare assumed to be rss feeds. In reality they could refer to either rss or atom feeds. This commit improves the content type handling to attempt to parse either feed types when the content type istext/xmlorapplication/xml.In addition, the
Acceptheader of the outgoing requests is now set correctly according to the supported content types.