fix(config)!: change content_type from endpoint config #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the
content_type
in endpoint config is used to enforce the interpretation of the request body in a certain content type. This feature is useful on some feeds that reports wrong content types.Later I discovered that this feature is more generally needed. For example, in the upcoming merge filter, we may also want to assume the content_type for the merged source. So in this PR, I moved the
content_type
field from endpoint's config to the client's config. I also renamed it toassume_content_type
to make it more clear.BREAKING CHANGE: This change will break the existing configuration if you use
content_type
field in an endpoint. You need to update your endpoint config as follows: