feat(inspector-ui): add a reload button #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is necessary for the extension to be updated
shouya
added a commit
that referenced
this pull request
Feb 19, 2024
Add a reload button that reloads the config manually. In the future I may implement this to be automatic, probably with a websocket connection to the backend to detect reload events. For the time being, I think this button is a simple and good enough solution. In the passing I found a bug with the response in `_inspector/config` is not being updated when the config is reloaded. I fixed that as well. --------- Co-authored-by: Shou Ya <shouya@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a reload button that reloads the config manually.
In the future I may implement this to be automatic, probably with a websocket connection to the backend to detect reload events. For the time being, I think this button is a simple and good enough solution.
In the passing I found a bug with the response in
_inspector/configis not being updated when the config is reloaded. I fixed that as well.