-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(server): optimize reload logic #60
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This error type is used in both ConfigError and normal Error type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this branch is to support partial reloading.
Now we will only:
If an endpoint's config was untouched, we will reuse the existing endpoint. Same for any filters in the filter pipeline.
There are several benefits with this approach:
Aside from some logging changes, this branch should cause no functional difference.
It's not trivial to implement this feature. Doing so requires some architectural change in the server implementation. Previously the routes are statically added to the
axum::Router
. Now since the endpoints can be dynamically added and removed without restarting axum server, I have to implement a custom handler depend on a global instance of current config and endpoint state.In addition, I made a more clear separation between
Error
andConfigError
. Functions that are called during building the config into the service will only raiseConfigError
. The trait definition forFeedFilterConfig
has also been updated.