perf(filters): parallelize feed post-processing #61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized the post processing of the fetched html page is a bottleneck for the
full_text
filter. After profiling, I found:tendril
andhtml5ever
libraries, which is not easily optimized from this crate.So in this patch I moved the compute intensive part into separate tokio tasks so they can be computed at the same time.
For reference, before the change, the sample hackernews full text endpoint [1] takes around 9s to finish. With the request caching, it still takes around 4s. After the change, the uncached version takes 4s and cached version only take less than 1s (on my 8-core machine).
[1]: