feat(inspector-ui): authentication support #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56.
This pull request implements authentication support with a very simple login page:
You can specify a username and password in the config to protect the inspector UI behind the login page:
If the
authconfig is not specified, authentication will be disabled and the inspector UI is accessible publicly.Note: the login feature is implemented in a very primitive way for the sake of the simplicity. Only one single user can be logged in at the same time. This means if if you try to log in from another browser, the existing session will be invalidated. Also, there is no session expiration mechanism. To log out, use the "Logout" button from the inspector UI, or simply clear your cookie.