fix(filters): support early return in modify_post
and modify_feed
#72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the user code is embedded in a function that looks like this:
It means in the filter config, if the user wants to early return, they must call
return post;
explicitly. This is a little clumsy given we want to give the illusion that the user no longer has to explicitly return post or anything.I hope to enable the user to write code like this in
modify_post
andmodify_feed
filter:Because now the
return
statement for user code has different semantics from thereturn
statement ofmodify_post
function, we must wrap the user code in a different function.This pull request changes the wrapper we embedded user code to: