Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filters): mark client and filters optional for merge filter #77

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

shouya
Copy link
Owner

@shouya shouya commented Mar 9, 2024

Previously, the client and filters fields were required (but has a default value). One So if the user don't specify the client and filters fields, they'll default to a struct with the default values.

One side effect is that the inspector-ui will try render the all-empty field for client even if the user didn't specify it client their config.

With this change, I wrapped the client and filters fields with Option box, so now the client field will appear as null when rendered in json.

@shouya shouya merged commit 0bfbb01 into master Mar 9, 2024
2 checks passed
@shouya shouya deleted the optional-client-and-filters-in-full-merge-filter branch March 9, 2024 00:48
shouya added a commit that referenced this pull request Mar 9, 2024
Previously, the `client` and `filters` fields were required (but has a
default value). One So if the user don't specify the `client` and
`filters` fields, they'll default to a struct with the default values.

One side effect is that the inspector-ui will try render the all-empty
field for `client` even if the user didn't specify it `client` their
config.

With this change, I wrapped the `client` and `filters` fields with
`Option` box, so now the `client` field will appear as `null` when
rendered in json.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant