fix(filters): mark client and filters optional for merge filter
#77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shouya
added a commit
that referenced
this pull request
Mar 9, 2024
Previously, the `client` and `filters` fields were required (but has a default value). One So if the user don't specify the `client` and `filters` fields, they'll default to a struct with the default values. One side effect is that the inspector-ui will try render the all-empty field for `client` even if the user didn't specify it `client` their config. With this change, I wrapped the `client` and `filters` fields with `Option` box, so now the `client` field will appear as `null` when rendered in json.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
clientandfiltersfields were required (but has a default value). One So if the user don't specify theclientandfiltersfields, they'll default to a struct with the default values.One side effect is that the inspector-ui will try render the all-empty field for
clienteven if the user didn't specify itclienttheir config.With this change, I wrapped the
clientandfiltersfields withOptionbox, so now theclientfield will appear asnullwhen rendered in json.