feat: reliably detect config file modification #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shouya
force-pushed
the
watch-config-file-rename
branch
from
d82fbb1
to
16234fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #80, the fs watcher previously cannot detect config changes made using vim.
Vim's default save file behavior (controlled by
backupcopyoption) is to save the file under a new name and then rename it to override the original file. As such, the inode of the previously watched file is gone and will no longer triggers inotify events.This PR addresses the issue by additionally detecting file remove events, and re-launch the watcher on the same path when the file is found deleted.
In case the config file is truly deleted instead of being overridden, the watcher will wait indefinitely until the file has been recreated.
Fixes #80.