-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core path update #49
Core path update #49
Conversation
Hi. Thank you for your contribution. I'm at work right now, but I'll check and release the update today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating the path in the template is not enough. You need to update the regex in build script.
This is it:
Line 32 in 7b9b04b
/(<script src=")(node_modules\/@shower\/core\/)(shower.min.js"><\/script>)/g, |
If you don't want to get into the code, I can finish it myself tonight.
Huh, too late. Done :) |
Oh, and the filename too, please :) Line 37 in 7b9b04b
|
Done. It kinda makes you understand that it’s a bit too much hard-coded ;) |
Yes, I agree that it is worth making this dependency more flexible. |
I published version 0.3.0 in npm, with your PR. |
@shower/core is now released as v3.0.0 stable, so I’m currently moving the rest of the packages to the
@shower
organization. To publish the@shower/shower
package I need to update the cli with the new core path first.Would you mind checking my changes and releasing the new cli version? :)