-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update showheroes docs #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
12adabf
to
36cc92e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove qa.pageURL
dev-docs/bidders/showheroes-bs.md
Outdated
unitId: "AACBTwsZVANd9NlB", | ||
qa: { | ||
"endpoint": "https://vr-api.dev.showheroes.com/openrtb2/auction/", | ||
"pageURL": "https://testing.domain.com/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not needed anymore
dev-docs/bidders/showheroes-bs.md
Outdated
unitId: "AAFo8FVWXycNdR8K", | ||
qa: { | ||
"endpoint": "https://vr-api.dev.showheroes.com/openrtb2/auction/", | ||
"pageURL": "https://dev-pagetests.viralize.com/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dev-docs/bidders/showheroes-bs.md
Outdated
qa: { | ||
"endpoint": "https://vr-api.dev.showheroes.com/openrtb2/auction/", | ||
"pageURL": "https://testing.domain.com/" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion we should provide a specific param for testing (like testing: true
or preview: true
), instead of using qa
.
For our publishers, changing the endpoint does not make much sense.
dev-docs/bidders/showheroes-bs.md
Outdated
| `playerId` | required (if not send unitId) | VideoLibrary player ID | `'0151f985-fb1a-4f37-bb26-cfc62e43ec05'` | `string` | | ||
| `unitId` | required (if not send playerId) | Monetize unit ID | `'AACBTwsZVANd9NlB'` | `string` | | ||
| `vpaidMode` | optional | Vpaid wrapper; default: `false`. | `true` | `boolean` | | ||
| `unitId` | required | Monetize unit ID | `'AACBTwsZVANd9NlB'` | `string` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually our product is now called ShowHeroes MAX
dev-docs/bidders/showheroes-bs.md
Outdated
bids: [{ | ||
bidder: "showheroes-bs", | ||
params: { | ||
unitId: "AACBTwsZVANd9NlB", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Developers will use these parameters to test their config.
Here some open questions coming to my mind:
What unit id are we using here ?
Do we have a generic test unit created on our platform, that will be used during the integrations implementation?
Is our analytics tracking those test requests, or completely discarding it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed privately, we now provide fake zid.
When using the preview mode, a test ad will be returned, even if the zid is not valid.
No tracking will be performed on analytics.
When the developer will remove the preview mode, the bidder will stop returning any bids.
d72042d
to
288d8b6
Compare
Official PR opened: prebid#5627 |
🏷 Type of documentation
📋 Checklist