Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update showheroes docs #1

Closed
wants to merge 7 commits into from
Closed

Conversation

FilipStamenkovic
Copy link

🏷 Type of documentation

  • update bid adapter

📋 Checklist

Copy link

@musikele musikele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@musikele musikele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove qa.pageURL

unitId: "AACBTwsZVANd9NlB",
qa: {
"endpoint": "https://vr-api.dev.showheroes.com/openrtb2/auction/",
"pageURL": "https://testing.domain.com/"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not needed anymore

unitId: "AAFo8FVWXycNdR8K",
qa: {
"endpoint": "https://vr-api.dev.showheroes.com/openrtb2/auction/",
"pageURL": "https://dev-pagetests.viralize.com/"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed

Copy link

@musikele musikele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines 71 to 74
qa: {
"endpoint": "https://vr-api.dev.showheroes.com/openrtb2/auction/",
"pageURL": "https://testing.domain.com/"
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion we should provide a specific param for testing (like testing: true or preview: true), instead of using qa.
For our publishers, changing the endpoint does not make much sense.

dev-docs/bidders/showheroes-bs.md Outdated Show resolved Hide resolved
| `playerId` | required (if not send unitId) | VideoLibrary player ID | `'0151f985-fb1a-4f37-bb26-cfc62e43ec05'` | `string` |
| `unitId` | required (if not send playerId) | Monetize unit ID | `'AACBTwsZVANd9NlB'` | `string` |
| `vpaidMode` | optional | Vpaid wrapper; default: `false`. | `true` | `boolean` |
| `unitId` | required | Monetize unit ID | `'AACBTwsZVANd9NlB'` | `string` |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually our product is now called ShowHeroes MAX

dev-docs/bidders/showheroes-bs.md Outdated Show resolved Hide resolved
bids: [{
bidder: "showheroes-bs",
params: {
unitId: "AACBTwsZVANd9NlB",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Developers will use these parameters to test their config.
Here some open questions coming to my mind:

What unit id are we using here ?
Do we have a generic test unit created on our platform, that will be used during the integrations implementation?
Is our analytics tracking those test requests, or completely discarding it?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed privately, we now provide fake zid.

When using the preview mode, a test ad will be returned, even if the zid is not valid.
No tracking will be performed on analytics.

When the developer will remove the preview mode, the bidder will stop returning any bids.

dev-docs/bidders/showheroes-bs.md Outdated Show resolved Hide resolved
dev-docs/bidders/showheroes-bs.md Outdated Show resolved Hide resolved
@FilipStamenkovic
Copy link
Author

Official PR opened: prebid#5627

@FilipStamenkovic FilipStamenkovic deleted the showheroes_updates branch September 30, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants