Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Upgrade Next.js #1261

Merged
merged 14 commits into from
Jul 13, 2022
Merged

Upgrade Next.js #1261

merged 14 commits into from
Jul 13, 2022

Conversation

axeldelafosse
Copy link
Contributor

@axeldelafosse axeldelafosse commented Jul 5, 2022

Why

We want to use SWC

How

  • Upgraded Next.js and React
  • Used Reanimated SWC plugin

Test Plan

Run the web apps

@vercel
Copy link

vercel bot commented Jul 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
showtime ✅ Ready (Inspect) Visit Preview Jul 13, 2022 at 2:23PM (UTC)

@github-actions
Copy link

github-actions bot commented Jul 5, 2022

PR Preview - Storybook

This pull request preview deployment is now available.

✅ Preview: exp+io.showtime.storybook://expo-development-client/?url=https://u.expo.dev/e77d5b68-bb27-45da-aa5c-96c1fdbf6706&channel-name=pr-1261

Comment ID: 1175002318

@github-actions
Copy link

github-actions bot commented Jul 5, 2022

PR Preview - App

This pull request preview deployment is now available.

✅ Preview: exp+io.showtime.development://expo-development-client/?url=https://u.expo.dev/45cbf5d5-24fe-4aa6-9580-acf540651abd&channel-name=pr-1261

Comment ID: 1175013048

Copy link
Contributor

@catalinmiron catalinmiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

legacyBrowsers: false,
forceSwcTransforms: true,
esmExternals: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the default value

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes haha we discussed this on Slack. Forgot to remove it (again)

@axeldelafosse axeldelafosse marked this pull request as ready for review July 13, 2022 13:58
@github-actions
Copy link

github-actions bot commented Jul 13, 2022

PR Preview - Storybook on Chromatic

✅ Preview: The Storybook preview URL for this Pull Request

✅ Build: The Chromatic build URL for this Pull Request

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants