-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--recursive
flag trys to compress non png files
#547
Comments
This seems very sensible, I guess it's just never come up before. Feel free to open a PR 🙂 |
@LuckyTurtleDev If you are implementing this, maybe consider an option to retain the current behavior, as well? |
Note that regardless of how |
The problem is that due to the Windows globbing issues, |
Globbing is brittle on Windows (e.g., search "glob" in this repo's issues/PRs/commits & you'll see what I mean), b/c it's not a shell/system function, so switches like this are preferred there. |
I have impl this now and include a flag to keep the old behavior. |
The
--recursive
flag, does also try to compress non png files (even it is not even an image). Is their any reason, why the files are not filtered by.png
extension? This should speed up the recursive flag, since nonpng
files need not be considered.I can implement this, if this feature is wanted.
The text was updated successfully, but these errors were encountered: