Limit wall clock time spent on optimization trials #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shssoichiro
requested changes
Jul 11, 2018
src/lib.rs
Outdated
| @@ -158,6 +160,10 @@ pub struct Options { | |||
| /// | |||
| /// Default: 1.5x CPU cores, rounded down | |||
| pub threads: usize, | |||
|
|
|||
| /// Maximum amount of time to spend on optimizations. | |||
| /// Further potential optimizations are skiped if the timeout is exceeded. | |||
| struct Deadline { | ||
| start: Instant, | ||
| timeout: Option<Duration>, | ||
| print_message: Mutex<bool>, |
There was a problem hiding this comment.
Could this be accomplished with an AtomicBool?
There was a problem hiding this comment.
Probably, but the implementation would be less obvious. This path is very cold, so it wouldn't make any difference to performance. I'd rather not complicate it.
I'd use std::sync::Once for this if it was usable.
shssoichiro
approved these changes
Jul 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For automated optimization tools it's problematic when large images take very long time to optimize, so they have to have some time limit.
Simply killing the process when it takes too long is wasteful. It's better to keep existing work done and exit gracefully.
This PR adds a coarse-grained limit for maximum time spent on trying potential optimizations. For simplicity, it doesn't try to finish exactly within the given timeout, merely stops adding new work after a deadline.