Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix decoding interlaced images with height or width <= 2 #175

Merged
merged 4 commits into from
Jun 27, 2019

Conversation

fhanau
Copy link
Contributor

@fhanau fhanau commented Jun 14, 2019

Fixes decoding of interlaced images with height or width <= 2, which previously triggered an assertion as the iterator did not detect which passes are present in an image properly.

@fhanau
Copy link
Contributor Author

fhanau commented Jun 20, 2019

Test file created using convert -size 2x2 canvas:white -interlace PNG issue-175.png:
issue-175
https://user-images.githubusercontent.com/12156995/59851836-7ecf3700-9365-11e9-893f-92f838ec830c.png

@shssoichiro
Copy link
Owner

Thanks! Would you mind adding a regression test using that sample image? You can see how the other regression tests are set up under tests/regression.rs.

@fhanau
Copy link
Contributor Author

fhanau commented Jun 26, 2019

Done!

@shssoichiro
Copy link
Owner

Thanks!

@shssoichiro
Copy link
Owner

Looks like rustup is broken at the moment, so I'm going to merge this despite the red build.

@shssoichiro shssoichiro merged commit 56b9454 into shssoichiro:master Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants