Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit integration docs #589

Conversation

UnknownPlatypus
Copy link
Contributor

Hey !

Following the addition of pre-commit support, I've updated the docs with a small section to reflect that.

I've added this just above the trunk integration section.
Because pre-commit is open source while trunk is proprietary, it felt more appropriate to promote this option.

Let me know if you want me to make any changes.

Cheers

Copy link
Collaborator

@AlexTMjugador AlexTMjugador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! This is a nice addition to the documentation, thank you! ❤️

README.md Outdated Show resolved Hide resolved
@AlexTMjugador AlexTMjugador added the T-Docs Issues for adding or improving documentation label Jan 21, 2024
Copy link
Collaborator

@AlexTMjugador AlexTMjugador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's merge! 🚀

@AlexTMjugador AlexTMjugador merged commit 19ad370 into shssoichiro:master Jan 22, 2024
10 checks passed
@UnknownPlatypus UnknownPlatypus deleted the add-pre-commit-integration-docs branch January 22, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Docs Issues for adding or improving documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants