Release/9.1

[andrews05]

• Update changelog
• Bump version
• Regenerate manual (note the script required a tweak due to an update of terminal-size)

Changes in whitespace are due to previous changes made for mangen.

[AlexTMjugador]

Looks good! Before going forward with this I think I should give the deb archive changes a further look, as I have the impression that since you changed the cargo deb invocation to use the --no-build parameter it may not be necessary to install any cross-compilation toolchains.

Edit: nevermind most of the above, you stated it was needed for proper package dependency resolution by cargo deb... I wonder if there's a better solution to this.

[andrews05]

Yeah, the better solution is to wait for GitHub arm runners to be available (I believe they're currently in private beta). But I'm sure the current solution will suffice while we wait.

Just let me know when you're ready and I'll publish the release 🙂

[ace-dent]

@andrews05 I'm doing extensive testing with your palette sorting work. It is excellent, so well worth a point release! 🎉

[AlexTMjugador]

I've had some time to delve into the cargo deb dependencies matter, and it seems my suspicions were right. It turns out that we don't actually need the entire cross-compilation toolchain. cargo deb utilizes dpkg-shlibdeps behind the scenes to automatically resolve dependencies, and all dpkg-shlibdeps requires are the target shared libraries, which are conveniently provided by the libc6-arm64-cross and libgcc-s1-arm64-cross packages. These packages are lightweight and don't necessitate a full-blown multiarch setup. I've just pushed a commit with this enhancement, which I've tested on a x64 host within a clean Docker container.

Let's move forward with the release then! 🎉

[andrews05]

@AlexTMjugador Awesome, that looks much tidier, thanks for reworking that!

[andrews05]

@AlexTMjugador We've got a problem with the cargo publish.
Source directory was modified by build.rs during cargo publish. Build scripts should not modify anything outside of OUT_DIR.
https://doc.rust-lang.org/cargo/reference/build-scripts.html#outputs-of-the-build-script

I could run it with --no-verify for now if we think that's okay but we should definitely fix this going forward.
From my research, there really isn't any good way to handle generated files right now. Some options:

• Revert your change to the assets dir
• Use something like xtasks or cargo-make instead of using build.rs
• Make the manual.sh script also generate the manpage instead of using build.rs

Additionally, the deploy script didn't publish the release notes. It seems tail -n +2 need to be tail -n +3, though I'm a little confused - was this ever working? 🤔