Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Possible to provide an escape hatch for expressions #51

Merged
merged 8 commits into from
Sep 11, 2024
Merged

fix: Possible to provide an escape hatch for expressions #51

merged 8 commits into from
Sep 11, 2024

Conversation

wugeer
Copy link
Contributor

@wugeer wugeer commented Sep 9, 2024

fix: #15

shssoichiro
shssoichiro requested changes Sep 10, 2024
View reviewed changes
Copy link
Owner

@shssoichiro shssoichiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks really good overall, just one change recommended.

Cargo.toml Outdated Show resolved Hide resolved
shssoichiro
shssoichiro approved these changes Sep 11, 2024
View reviewed changes
Copy link
Owner

@shssoichiro shssoichiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@shssoichiro shssoichiro merged commit 2305a5e into shssoichiro:master Sep 11, 2024
5 checks passed
@max-sixty
Copy link

Awesome, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shssoichiro shssoichiro shssoichiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possible to provide an escape hatch for expressions?
3 participants
@wugeer @max-sixty @shssoichiro