#2 ensure no side effects on modifying the results

shubhranshu · Apr 26, 2020 · 31dabb7 · 31dabb7
1 parent 363c136
commit 31dabb7
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 21 deletions.
diff --git a/src/index.js b/src/index.js
@@ -37,8 +37,8 @@ const calculateRatio = (x, y) => {
   }
 
   return {
-    match,
-    sortedRatios,
+    match: { ...match },
+    sortedRatios: [...sortedRatios],
   };
 };
 

diff --git a/test/sample.js b/test/sample.js
diff --git a/test/testRatios.js b/test/testRatios.js
diff --git a/test/tests.js b/test/tests.js
@@ -0,0 +1,22 @@
+import test from 'ava';
+import { calculateRatio } from '../src/index';
+
+test('constructor is ok', (t) => {
+  var rslt = calculateRatio(2, 1);
+  t.pass();
+});
+
+test('test ratio 2:1', (t) => {
+  var rslt = calculateRatio(2, 1);
+  t.assert(rslt.match.ratio === '2:1');
+});
+
+test('test result modifications has no side effects', (t)=>{
+  var rslt = calculateRatio(2, 1);
+  t.assert(rslt.match.ratio === '2:1');
+  delete rslt.match.ratio;
+  var rslt = calculateRatio(200, 100);
+  t.assert(rslt.match.ratio === '2:1');
+})
+
+test