Fix #162: Removes panic in Autostart package #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Panic in Auotstart::create_autostart_file hang up the application. Log
example:
```
*** unhandled exception in callback:
*** Not a directory at /usr/share/perl5/Shutter/App/Autostart.pm line 59.
*** Shutter::App::Autostart::create_autostart_file(Shutter::App::Autostart=HASH(0x555ef7853e08), "/home/user/.config/autostart", "", "", "") called at /usr/bin/shutter line 3189
*** Shutter::App::__ANON__() called at /usr/lib/x86_64-linux-gnu/perl5/5.38/Glib/Object/Introspection.pm line 67
*** eval {...} called at /usr/lib/x86_64-linux-gnu/perl5/5.38/Glib/Object/Introspection.pm line 67
*** Glib::Object::Introspection::__ANON__(Shutter::App=HASH(0x555ef76dcf20)) called at /usr/bin/shutter line 10943
*** ignoring at /usr/lib/x86_64-linux-gnu/perl5/5.38/Glib/Object/Introspection.pm line 67.
```
|
Does it show a message or only writes to console? |
|
It only writes to console. |
|
Would it be possible to merge this? It fixes a problem for people who don't want to have it in autostart (or autostart isn't writable for different reason) and has no changes for others. |
vadi2
approved these changes
Mar 26, 2024
Photon89
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Panic in Auotstart::create_autostart_file hang up the application. Log
example: