Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify Secrets.toml format in Docs. #114

Merged
merged 2 commits into from
Jun 9, 2023
Merged

Specify Secrets.toml format in Docs. #114

merged 2 commits into from
Jun 9, 2023

Conversation

laundmo
Copy link
Contributor

@laundmo laundmo commented May 29, 2023

No description provided.

oddgrd
oddgrd reviewed May 31, 2023
View reviewed changes
Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a good addition! Maybe this should rather be the second paragraph under the ## Usage header, though, what do you think?

resources/shuttle-secrets.mdx Outdated Show resolved Hide resolved
@laundmo
Copy link
Contributor Author

laundmo commented Jun 7, 2023

updated, feel free to comment again

oddgrd
oddgrd approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@oddgrd oddgrd merged commit 0ba5f1a into shuttle-hq:main Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshua-mo-143 joshua-mo-143 joshua-mo-143 left review comments

@oddgrd oddgrd oddgrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laundmo @oddgrd @joshua-mo-143