Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add documentation for rocket dyn_template example #76

Conversation

jhawkesworth
Copy link

Documentation for shuttle docs site for the example that was recently merged under shuttle-hq/shuttle-examples#38

@jhawkesworth
Copy link
Author

@oddgrd documentation as requested.

@joshua-mo-143
Copy link
Member

@oddgrd Apologies for the re-ping but it looks like this has been open for quite a while with no update - should we be merging this in accordance with the previously merged PR for shuttle-examples?

@oddgrd
Copy link
Contributor

oddgrd commented Jun 13, 2023

Oh, sorry @jhawkesworth! I saw this way back but then forgot to get back to it. I'm not sure we can merge this now since the docs for rocket have been mostly pulled out. I believe this is up for discussion though, so we could consider including this if we bring rocket docs back to the front.

@jhawkesworth
Copy link
Author

As things stand the core team have more important things to get done so let's close this. Sometimes PRs just arrive at the wrong moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants