Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: changing '/hello' routes to '/' #41

Merged
merged 3 commits into from
May 5, 2023
Merged

feat: changing '/hello' routes to '/' #41

merged 3 commits into from
May 5, 2023

Conversation

mikegin
Copy link
Contributor

@mikegin mikegin commented May 2, 2023 •
edited
Loading

shuttle-hq/shuttle#841

Related PR in shuttle repo: shuttle-hq/shuttle#863

@mikegin mikegin mentioned this pull request May 4, 2023
Merged
@mikegin mikegin marked this pull request as ready for review May 4, 2023 14:38
oddgrd
oddgrd approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @paulotten and @mikegin, this LGTM too!

@oddgrd oddgrd merged commit e5f253c into shuttle-hq:main May 5, 2023
@paulotten paulotten mentioned this pull request May 5, 2023
Closed
1 task
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulotten paulotten paulotten approved these changes

@oddgrd oddgrd oddgrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikegin @paulotten @oddgrd