Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement]: Examples CI: Modified workflow for the develop branch #1633

Closed
jonaro00 opened this issue Feb 22, 2024 · 1 comment
Closed
Assignees
Labels
Contribution Wanted The community is welcome to collaborate on this issue Good First Issue Good for newcomers S-Accepted This will be worked on T-Improvement Improvement or addition to existing features

Comments

@jonaro00
Copy link
Member

jonaro00 commented Feb 22, 2024

In shuttle-examples, the CI workflow for main and develop is the same.
When breaking changes are made on the develop branch, the CI checks will fail since they run against the last released versions of the shuttle crates.

The idea is to make a separate workflow for the develop branch that does the same things as the current one, but before running checks, checkout the main branch of the main repo, and run the scripts/apply-patches.sh script so that compilation will use the checked out code.

To work on this, simply open a PR to examples' develop branch, and (after we run it) you will know it works if the compilation messages say that the crates are local paths.


This issue is open to contribution. Comment if you want to work on it. Feel free to ask for help and guidance here or in our Discord.

@jonaro00 jonaro00 added T-Improvement Improvement or addition to existing features S-Triage Awaiting decision for what to do Good First Issue Good for newcomers Contribution Wanted The community is welcome to collaborate on this issue S-Accepted This will be worked on and removed S-Triage Awaiting decision for what to do labels Feb 22, 2024
@sourabpramanik
Copy link
Contributor

This looks interesting, I want to take it up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Wanted The community is welcome to collaborate on this issue Good First Issue Good for newcomers S-Accepted This will be worked on T-Improvement Improvement or addition to existing features
Projects
None yet
Development

No branches or pull requests

2 participants