-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: use patches for shuttle/main on develop branch #154
ci: use patches for shuttle/main on develop branch #154
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I also thought that we needed two files, but wouldn't it be better to check with github variables if we are on the devlop branch, and use that to conditionally trigger the steps where the checkout+patches happen? Then we can have one file.
…ples into feat/dev-ci-workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, but some things to fix:
Co-authored-by: jonaro00 <54029719+jonaro00@users.noreply.github.com>
Co-authored-by: jonaro00 <54029719+jonaro00@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though the workflow is currently failing, the steps we want are working correctly now. It should work again when the 0.42.0 PR is merged in the main repo.
Description of change
This PR adds a new GitHub workflow only for the develop branch.
Related issue: #1633
How has this been tested? (if applicable)
Approving the PR