Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement]: bump Shuttle's pinned rust version to 1.70 #964

Closed
1 task done
oddgrd opened this issue Jun 2, 2023 · 1 comment · Fixed by #967
Closed
1 task done

[Improvement]: bump Shuttle's pinned rust version to 1.70 #964

oddgrd opened this issue Jun 2, 2023 · 1 comment · Fixed by #967
Labels
T-Improvement Improvement or addition to existing features

Comments

@oddgrd
Copy link
Contributor

oddgrd commented Jun 2, 2023

Describe the improvement

We should bump the pinned version of rustc to 1.70 (in the Makefile and CI). With 1.70 (and possibly 1.69) also came some new language features, we should see if we can benefit from implementing some of these. For example in 1.70 OnceCell was added to the standard library, and a new method on options/results: is_some_and/is_ok_and. If there are any major changes we should implement, it should be a separate PR.

PS. in 1.70 sparse registries is enabled by default, so we can remove the CARGO_REGISTRIES_CRATES_IO_PROTOCOL: "sparse" env from our CI.

Release notes:

Duplicate declaration

  • I have searched the issues and this improvement has not been requested before.
@oddgrd oddgrd added T-Improvement Improvement or addition to existing features S labels Jun 2, 2023
@iamwacko
Copy link
Contributor

iamwacko commented Jun 2, 2023

LazyLock is still experimental, and that is what we use OnceCell for, so the OnceCell inclusion won't affect much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Improvement Improvement or addition to existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants