-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: bump pinned Rust to 1.70 #967
Conversation
|
cimg-rust#110 Has that image coming up. Could be a moot point. |
…tually just to trigger CI)
… what is causing Rocket to fail
I made a whole bunch of commits thinking changes I had made were causing the rocket tests to fail, but now that I took a look at the tests in main I see that all that effort was for nothing. That also means that this should be ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies again for the CI confusion!
I left a comment about the clippy lint, I think we should rather refactor it. If we do ignore a clippy lint we should leave a comment about why as well. Regarding the once_cell
that's fine, we can do it in a separate PR/later when the LazyCell equivalent is stabilized.
#821 strikes again, with a side of errors of unknown cause. I'm getting the error below for all of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for this @iamwacko! I believe the deployer tests are spurious and not related to this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @iamwacko !
@@ -20,7 +20,6 @@ http-body = { version = "0.4.5", optional = true } | |||
http-serde = { version = "1.1.2", optional = true } | |||
hyper = { workspace = true, optional = true } | |||
jsonwebtoken = { workspace = true, optional = true } | |||
once_cell = { workspace = true, optional = true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: running a cargo sort might put the dep here again.
Description of change
Closes #964