-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: project delete #1307
feat: project delete #1307
Conversation
4dbdbb8
to
bf3797e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! I left a few comments, but this seems very close!
Could we also expand some of the gateway integration tests to test project deletion? |
General +1 from me, will check again once @oddgrd's review points are addressed. |
2090332
to
f2fab05
Compare
… gateway endpoint
… command (caveat in testcase)
f2fab05
to
5b39ece
Compare
Can we do this? At least a project without resources shouldn't be too tricky. |
Description of change
How has this been tested? (if applicable)
Tested locally with only with a rocket postgres app.
Deletion works while building a deployment.
The deletion isn't fully atomic, but it should be good enough.