Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: project delete #1307

Merged
merged 17 commits into from
Oct 23, 2023
Merged

feat: project delete #1307

merged 17 commits into from
Oct 23, 2023

Conversation

jonaro00
Copy link
Member

@jonaro00 jonaro00 commented Oct 5, 2023

Description of change

  • CLI command
  • Gateway endpoint
  • Handle checks for deployment and databases linked
  • Handle deletion of container and volume
  • Delete record from gateway DB
  • (do this for later release) "soft delete" a.k.a. perform the deletion of cont+vol but don't give up the name. good for "hard resets". I imagine "project start" will become "project claim" in the future. This makes sense at that point.
  • TESTING....
  • Remove CI comment

How has this been tested? (if applicable)

Tested locally with only with a rocket postgres app.
Deletion works while building a deployment.
The deletion isn't fully atomic, but it should be good enough.

@jonaro00 jonaro00 force-pushed the feat/eng-1500-project-delete branch from 4dbdbb8 to bf3797e Compare October 9, 2023 18:56
@jonaro00 jonaro00 marked this pull request as ready for review October 16, 2023 17:00
Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I left a few comments, but this seems very close!

gateway/src/api/latest.rs Outdated Show resolved Hide resolved
gateway/src/api/latest.rs Outdated Show resolved Hide resolved
gateway/src/api/latest.rs Outdated Show resolved Hide resolved
gateway/src/service.rs Show resolved Hide resolved
gateway/src/service.rs Outdated Show resolved Hide resolved
cargo-shuttle/src/lib.rs Show resolved Hide resolved
cargo-shuttle/src/client.rs Show resolved Hide resolved
@oddgrd
Copy link
Contributor

oddgrd commented Oct 17, 2023

Could we also expand some of the gateway integration tests to test project deletion?

@orhun
Copy link
Contributor

orhun commented Oct 17, 2023

General +1 from me, will check again once @oddgrd's review points are addressed.

@Kazy Kazy self-requested a review October 18, 2023 09:21
@jonaro00 jonaro00 force-pushed the feat/eng-1500-project-delete branch from 2090332 to f2fab05 Compare October 18, 2023 20:49
cargo-shuttle/src/lib.rs Show resolved Hide resolved
cargo-shuttle/src/client.rs Show resolved Hide resolved
@jonaro00 jonaro00 force-pushed the feat/eng-1500-project-delete branch from f2fab05 to 5b39ece Compare October 19, 2023 12:58
gateway/src/service.rs Outdated Show resolved Hide resolved
@oddgrd
Copy link
Contributor

oddgrd commented Oct 23, 2023

Could we also expand some of the gateway integration tests to test project deletion?

Can we do this? At least a project without resources shouldn't be too tricky.

.circleci/config.yml Outdated Show resolved Hide resolved
cargo-shuttle/src/lib.rs Show resolved Hide resolved
deployer/src/runtime_manager.rs Outdated Show resolved Hide resolved
gateway/src/api/latest.rs Outdated Show resolved Hide resolved
gateway/src/api/latest.rs Show resolved Hide resolved
gateway/src/main.rs Outdated Show resolved Hide resolved
@oddgrd oddgrd merged commit e9cf8fe into main Oct 23, 2023
@oddgrd oddgrd deleted the feat/eng-1500-project-delete branch October 23, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants