feat(cargo-shuttle): raw table output, fix table column alignment

[supleed2]

Description of change

• Closes [Improvement]: --raw parameter for commands that print tables #1315 by adding --raw flag to deployment list and project list commands, as well as resource list and secrets
• Closes [Bug]: status column values are misaligned in project list table output #962 by removing colouring from impl Display for Project::State
• Functions get_table in two locations renamed to get_projects_table/get_secrets_table to match naming of get_deployments_table
• New raw table format ignores terminal width and has no borders
• Project state returns &str like Deployment state, impl Display for state has no styling, styling done at call site when appropriate
• Commands --raw flag do not output styled messages when flag is used

How has this been tested? (if applicable)

The following commands were run, inspecting the output manually: (nano is a project I have running)

• cargo run --bin cargo-shuttle -- --api-url https://api.shuttle.rs deployment list --name nano
• cargo run --bin cargo-shuttle -- --api-url https://api.shuttle.rs deployment list --name nano --raw
• cargo run --bin cargo-shuttle -- --api-url https://api.shuttle.rs project list
• cargo run --bin cargo-shuttle -- --api-url https://api.shuttle.rs project list --raw
• cargo run --bin cargo-shuttle -- --api-url https://api.shuttle.rs resource list --name nano
• cargo run --bin cargo-shuttle -- --api-url https://api.shuttle.rs resource list --name nano --raw
• cargo run --bin cargo-shuttle -- --api-url https://api.shuttle.rs secrets --name nano
• cargo run --bin cargo-shuttle -- --api-url https://api.shuttle.rs secrets --name nano --raw

[jonaro00]

Looking good at a glance. Will try it out later. Anything else to add?

[supleed2]

Just wanted to look though and make sure I didn't miss anything, I'm happy with it yeah.

[oddgrd]

This looks great, thanks!

[jonaro00]

I see that the raw project list will use colors, but not the deployment list. I think colorless is preferred for raw table. Is this a quick fix or is it complicated due to #962 ?

[supleed2]

I see that the raw project list will use colors, but not the deployment list. I think colorless is preferred for raw table. Is this a quick fix or is it complicated due to #962 ?

The project list only applies colours when raw is false, or did I miss something? 😅

[jonaro00]

@supleed2

[supleed2]

I've rebased my new changes on master so it can be more easily merged. The changes should now close #1315 and also close #962. Thanks for noticing the coloured output @jonaro00

Edit: I see the failing tests, I'm going through them now

Edit 2: Took a few tries, but looks like it went better this time :D

[jonaro00]

Great job! 🥳
I simplified some unnecessary complexity. I'll let @oddgrd check one final time.

[oddgrd]

This looks great, but we are now missing the color on the project state in commands like cargo shuttle status and cargo shuttle project stop/start`, which I thought was quite nice. I assume it's because we applied the color for project states everywhere, and that is what was causing the misalignment bug, but is there any chance we can get the color back for these other commands?

[supleed2]

I'm going through the commands to check, but the output from cargo shuttle status is still coloured, due to these lines: https://github.com/shuttle-hq/shuttle/blob/main/common/src/models/service.rs#L44-L47

I think I've managed to restore colour to the rest of the commands, so I'll add that to my commit and rebase on main again in a bit. Thanks again for the spot!

@jonaro00 I also noticed while going through the commands that cargo shuttle resource list and cargo shuttle secrets have table output, should I add a --raw flag for those commands too?

[supleed2]

I decided to implement the --raw flag for resource list and secrets as well as rebasing on main, hopefully no merge conflicts arise later :)

This did include fixing a couple merge issues from the new project delete command, but I think it looks right now. And the status and project status commands now output coloured statuses almost as before, the whole message is coloured rather than just the first word for operations with counts.

[oddgrd]

Excellent work, thank you! ❤️ By the way, in the future, it's preferable if you don't squash your commits after the review process has started, since it makes it harder for us to distinguish the changes you made to address reviews. We will squash them when we merge the PR.