Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(installer): read input from process' controlling terminal #1327

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

orhun
Copy link
Contributor

@orhun orhun commented Oct 18, 2023

Description of change

Fixes the following installer error:

Detected Linux!
Checking distro...
lsb_release could not be found. Falling back to /etc/os-release
Installing with package manager is not supported
Please answer yes or no.
Please answer yes or no.
Please answer yes or no.
Please answer yes or no.
Please answer yes or no.
Please answer yes or no.
Please answer yes or no.
Please answer yes or no.

How has this been tested? (if applicable)

I was able to reproduce this on my ARM system and now it works.

Also see: https://www.unix.com/shell-programming-and-scripting/266010-bash-how-do-read-p-inside-while-loop.html

@jonaro00 jonaro00 merged commit 02369f5 into shuttle-hq:main Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants