Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gateway): project limit #1331

Merged
merged 9 commits into from
Nov 2, 2023
Merged

feat(gateway): project limit #1331

merged 9 commits into from
Nov 2, 2023

Conversation

jonaro00
Copy link
Member

@jonaro00 jonaro00 commented Oct 20, 2023 •
edited
Loading

Description of change

Temporary limits for the first release.

How has this been tested? (if applicable)

Works locally
image

orhun
orhun reviewed Oct 20, 2023
View reviewed changes
common/src/models/error.rs Outdated Show resolved Hide resolved
jonaro00 and others added 2 commits October 21, 2023 01:24
@jonaro00 @orhun
Wording
89874bb 
Co-authored-by: Orhun Parmaksız <orhunparmaksiz@gmail.com>
@jonaro00
feat: project limits per tier
6af20a6
oddgrd
oddgrd reviewed Oct 25, 2023
View reviewed changes
Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think we just need to discuss what these initial limits will be. Having them higher at first makes sense, I think, since some users might need support to be able to delete projects.

gateway/src/service.rs Show resolved Hide resolved
common/src/claims.rs Outdated Show resolved Hide resolved
iulianbarbu
iulianbarbu reviewed Oct 31, 2023
View reviewed changes
common/src/claims.rs Outdated Show resolved Hide resolved
common/src/constants.rs Outdated Show resolved Hide resolved
oddgrd
oddgrd approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I just left some comment suggestions.

common/src/claims.rs Outdated Show resolved Hide resolved
gateway/src/service.rs Show resolved Hide resolved
@oddgrd oddgrd merged commit 574b7b8 into shuttle-hq:main Nov 2, 2023
@jonaro00 jonaro00 deleted the project-limit branch November 2, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orhun orhun orhun left review comments

@iulianbarbu iulianbarbu iulianbarbu left review comments

@oddgrd oddgrd oddgrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonaro00 @iulianbarbu @orhun @oddgrd