Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cargo-shuttle): state MSRV in Cargo.toml #1356

Merged
merged 1 commit into from
Oct 30, 2023
Merged

feat(cargo-shuttle): state MSRV in Cargo.toml #1356

merged 1 commit into from
Oct 30, 2023

Conversation

jonaro00
Copy link
Member

@jonaro00 jonaro00 commented Oct 30, 2023 •
edited
Loading

Description of change

Should allow cargo to deny the install if outdated.
TODO: eventually add CI for checking this when we care more about it.

ref: shuttle-hq/shuttle-docs#210

How has this been tested? (if applicable)

Installing with 1.69 fails, 1.70 works ✔️

orhun
orhun approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe state this in the documentation as well?

@jonaro00
Copy link
Member Author

See the linked PR ;)

@jonaro00 jonaro00 merged commit f4ddaa6 into shuttle-hq:main Oct 30, 2023
@jonaro00 jonaro00 deleted the rust-version branch October 30, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orhun orhun orhun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonaro00 @orhun