feat: adapative page hints (client-side only) #1357
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Adds adaptive page hints to cargo-shuttle by adding 1 to the specified limit and checking if we reach that adjusted limit. This is not breaking as it requires no API changes and is just a small change to client-side logic. Only thing worth mentioning is technically you can only specify a limit up
u32::MAX - 1
because we always adjust the limit to belimit + 1
however I cannot really see a case where someone would ever need that high of a limit so it is basically irrelevant.Closes issue #1316
Also can close my other 2 PRs #1334 and #1320 as this resolves all the issues addressed in those.
How has this been tested? (if applicable)
Tested with local setup