improvement: rocket 0.5.0-rc.4 #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Bumped rocket to version 0.5.0-rc.4 in the dependencies section of Cargo.toml, under /services/shuttle-rocket. I studied the list of breaking changes and they don't appear to impact implementation of the Shuttle Service trait for Rocket.
How has this been tested? (if applicable)
There don't seem to be any integration tests within the services crate for shuttle-rocket. There also doesn't seem to be any unit tests. I ran
make testfrom the root of my repo, but the tests seemed to fail and I don't quite understand why. Doing a trial PR to trigger CI and see what I get.