-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auth: use a centrally stored jwt signing private key #1402
auth: use a centrally stored jwt signing private key #1402
Conversation
62b2f78
to
eeac485
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense! I left one question.
771ec52
to
cc88518
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice!! 🥳
Left small comments.
4e13fa4
to
ec21ef7
Compare
84e917e
to
565d4b6
Compare
565d4b6
to
31a96fd
Compare
31a96fd
to
220df0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit
Co-authored-by: Pieter <pieter@chesedo.me>
Description of change
We want our auth service to not generate a new private key for JWT signing at each release. This change should help in not invalidating the cached JWTs on the gateway when auth is released in isolation.
docker-compose.dev.yml
, to not require setting it up in the environment before starting the stack locally (the secret is compromised since it is stored in version control and we shouldn't use it for anything outside local development).How has this been tested? (if applicable)
JWT conversion
happened in auth while doing 4 (meaning a cached JWT was used successfully).