Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: better feature scoping, fix turso compilation, prune library dependency tree #1405

Merged
merged 5 commits into from
Nov 21, 2023
Merged

refactor: better feature scoping, fix turso compilation, prune library dependency tree #1405

merged 5 commits into from
Nov 21, 2023

Conversation

jonaro00
Copy link
Member

@jonaro00 jonaro00 commented Nov 19, 2023 •
edited
Loading

Description of change

Only refactorings, no changes.

  • Prunes the dependency weight by proto by a lot, which affects all resource libs
    • Fixes turso example compiling (no sqlx / sqlite crates in our tree exposed)
    • Axum hello world dependency tree: 366 -> 266 !!
    • Cargo-shuttle release build tree: 605 -> 416 !!!!!!! compile time (20 threads) 70s -> 51s (-27%)
  • moved runtime::start out of proto 😎

How has this been tested? (if applicable)

  • Clippy every crate individually
  • CI
  • Check all examples with patches
  • anything else?

oddgrd
oddgrd approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice reduction in dependencies exposed to users! 🥳 It would also be nice to know what the reduction in build time will be from this PR.

cargo-shuttle/Cargo.toml Outdated Show resolved Hide resolved
chesedo
chesedo reviewed Nov 21, 2023
View reviewed changes
Copy link
Contributor

@chesedo chesedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! Just have the same nit at O.

@jonaro00
Copy link
Member Author

cargo-shuttle release compile time (20 threads) 70s -> 51s (-27%)

@jonaro00 jonaro00 merged commit 569e831 into shuttle-hq:main Nov 21, 2023
@jonaro00 jonaro00 deleted the refactor-proto branch November 21, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chesedo chesedo chesedo left review comments

@oddgrd oddgrd oddgrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonaro00 @chesedo @oddgrd