Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cargo-shuttle): ability to force a name to be used in init #1410

Merged
merged 9 commits into from
Nov 22, 2023

Conversation

jonaro00
Copy link
Member

@jonaro00 jonaro00 commented Nov 21, 2023

Description of change

Useful if you are initing a project with a name that you already own.

--force-name arg disabled name validation and taken check.
In interactive, "reply" with the same name again to a failed validation to use the name anyways.

How has this been tested? (if applicable)

All combinations of with/without arg and with/without interactive works as expected.

@jonaro00 jonaro00 changed the title Feat force name feat(cargo-shuttle): ability to force a name to be used in init Nov 21, 2023
Copy link
Contributor

@chesedo chesedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused with this PR. Why do we need it? And why all the force variants?

cargo-shuttle/src/args.rs Outdated Show resolved Hide resolved
cargo-shuttle/src/lib.rs Outdated Show resolved Hide resolved
cargo-shuttle/tests/integration/init.rs Show resolved Hide resolved
Copy link
Contributor

@chesedo chesedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One extra comment

cargo-shuttle/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@chesedo chesedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think it can still be combined

cargo-shuttle/src/lib.rs Outdated Show resolved Hide resolved
@jonaro00 jonaro00 merged commit 8e6deae into shuttle-hq:main Nov 22, 2023
@jonaro00 jonaro00 deleted the feat-force-name branch November 22, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants