bug: remove project resources automatically when delete the project #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonaro00
reviewed
Nov 24, 2023
There was a problem hiding this comment.
Dry run flag is not being respected in handler. Ideally, the dry run flag will instead of deleting resources, return a list of them and let the user confirm the deletion of those resources. But we can also just display "...will delete ALL resources!!!" and let it go through after just the initial confirmation in CLI.
oddgrd
reviewed
Nov 27, 2023
oddgrd
approved these changes
Nov 27, 2023
gateway/src/api/project_caller.rs
Outdated
Comment on lines
99
to
103
| if let Some(deployments) = deployments { | ||
| Ok(deployments) | ||
| } else { | ||
| Ok(Vec::new()) | ||
| } |
There was a problem hiding this comment.
Nit: should we use Ok(deployments.unwrap_or_default()? Same in get_resources below.
There was a problem hiding this comment.
We sure can 😍 Thanks O!
chesedo
deleted the
feature/eng-1882-delete-project-resources-when-delete-request-is-received
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This causes a delete project request to try and remove all the resources automatically if possible. Else return a helpful error message.
How has this been tested? (if applicable)
By adding new tests