Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gateway): uppercase old ulids #1424

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

jonaro00
Copy link
Member

@jonaro00 jonaro00 commented Nov 25, 2023

Description of change

How has this been tested? (if applicable)

Worked locally on two dummy rows.
Needs to test on unstable.

Copy link
Contributor

@chesedo chesedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too! Did you test it on staging yet?

@jonaro00 jonaro00 force-pushed the uppercase-ulid branch 2 times, most recently from aa3bea8 to a74978b Compare January 17, 2024 14:45
@jonaro00
Copy link
Member Author

Worked on unstable ✔️

@jonaro00 jonaro00 merged commit f23703e into shuttle-hq:main Jan 17, 2024
0 of 35 checks passed
@jonaro00 jonaro00 deleted the uppercase-ulid branch January 17, 2024 14:52
jonaro00 added a commit that referenced this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants