feat: protect pro tier projects and our services #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While implementing the ability to allow pro users to start project above the soft limit I could not understand why the tests kept failing. Eventually found is was because gateway thought these were basic users. This happened because our mock auth only tracked scopes and not the actual tiers of users it managed.
oddgrd
approved these changes
Nov 30, 2023
Comment on lines
+963
to
+971
| let has_capacity = if current_container_count < self.cch_container_limit { | ||
| true | ||
| } else if current_container_count < self.soft_container_limit { | ||
| !is_cch_project | ||
| } else if current_container_count < self.hard_container_limit { | ||
| matches!(account_tier, AccountTier::Pro) | ||
| } else { | ||
| false | ||
| }; |
There was a problem hiding this comment.
Should we add tracing events with the count if we are over any of the limits?
There was a problem hiding this comment.
I'm honestly not sure. Because of the ambulance event (in the other PR) we can already setup a honeycomb alert. So I want to add a warn! in this function but don't see how it will be useful considering the ambulance event.
There was a problem hiding this comment.
True, it's likely overkill. 👍
jonaro00
approved these changes
Dec 1, 2023
oddgrd
deleted the
feature/eng-1985-add-a-pull-the-plug-for-all-non-pro-projects
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Prevent the creation of new projects or the starting of idle projects that will overload our servers
How has this been tested? (if applicable)
Updating the tests