fix(cargo-shuttle): remove newline from errored project state output #1466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oddgrd
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Thanks! That's a good idea, we'll make a note of it. We do have a staging environment, but it's not public. Once we add more in the future, we can consider something like this that would make it easier for contributors. 👍 For now, it should be possible to test this by manually editing the gateway project state and setting it to errored, I think.
|
Modifying the project state to something invalid will cause an errored state IIRC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Updates
impl Display for Stateto remove tab and newline from errored project state, which caused issues with the table output as shown in #1451.Closes #1451.
How has this been tested?
The project I would use to test has stopped now, so I don't have one in an errored state, but this change is very localised and does not affect control flow, only text output.
Sidenote
In future it would be cool to have a testing API url which has a range of dummy projects / states, but that's for another issue :)