Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(shuttle-serenity): make serenity 0.12 default, support poise 0.6, deprecate shuttle-poise #1521

Merged
merged 10 commits into from
Jan 23, 2024
Merged

feat(shuttle-serenity): make serenity 0.12 default, support poise 0.6, deprecate shuttle-poise #1521

merged 10 commits into from
Jan 23, 2024

Conversation

supleed2
Copy link
Contributor

Description of change

  • Adds poise and poise-0-6 feature flags, with poise enabled by default
  • Note similar to shuttle-serenity added to readme

How has this been tested? (if applicable)

  • cargo clippy
  • cargo clippy --no-default-features -F poise-0-6

@jonaro00
Copy link
Member

Thanks for the PR! :D
I think it'll soon be time for switching the serenity plugin to use 0.12 by default (a PR that you can do if you want to), so I think having this released at the same time with 0.6 as the default feature will be good.

@supleed2
Copy link
Contributor Author

Sounds great, all that's needed for that is changing the defaults? So:

default = ["poise"] -> default = ["poise-0-6"]
default = ["rustls_backend"] -> default = ["serenity-0-12-rustls_backend"]

@jonaro00
Copy link
Member

Rather with a new feature for the older version, and no feature for the current one. See the shuttle-axum crate.

@supleed2
Copy link
Contributor Author

Ah right, I get what you mean. I've made it match shuttle-axum. Should I make a separate PR now for serenity too?

@jonaro00
Copy link
Member

Since the changes are so closely related, I don't mind having both changes in one PR. Either way works.

@jonaro00 jonaro00 changed the title feat(shuttle-poise): Add support for Poise 0.6 feat(shuttle-poise, shuttle-serenity): support poise 0.6, make serenity 0.12 default Jan 18, 2024
@jonaro00
Copy link
Member

@supleed2 You can restore shuttle-poise to its state before this PR, change the requirement on shuttle-runtime to <=0.40.0, add a #[deprecated = "..." ] on the PoiseService. The readme and the deprecation message can have a link to the latest docs.rs/shuttle-serenity.

Then there is also an opportunity to update the examples to use the newer versions of serenity and poise. 😉

@jonaro00 jonaro00 changed the title feat(shuttle-poise, shuttle-serenity): support poise 0.6, make serenity 0.12 default feat(shuttle-serenity): make serenity 0.12 default, support poise 0.6, deprecate shuttle-poise Jan 23, 2024
@jonaro00 jonaro00 mentioned this pull request Jan 23, 2024
Merged
@jonaro00 jonaro00 merged commit d6e6a46 into shuttle-hq:main Jan 23, 2024
34 of 37 checks passed
jonaro00 added a commit that referenced this pull request Jan 24, 2024
@supleed2 @jonaro00
feat(shuttle-serenity): make serenity 0.12 default, support poise 0.6…
d6df250 
…, deprecate shuttle-poise (#1521)

* feat(shuttle-poise): Add support for Poise 0.6

Adds `poise` and `poise-0-6` feature flags, with `poise` enabled by default

* ci: fix tests with poise feature flags

* ci: poise ignore doctest

* feat(shuttle-poise): make poise 0.6 default

* feat(shuttle-serenity): make serenity 0.12 default

* chore(shuttle-poise): deprecate shuttle-poise

* docs(shuttle-serenity): mention poise 0.6

* ci: restore poise ci config

* chore: bump examples

---------

Co-authored-by: jonaro00 <54029719+jonaro00@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oddgrd oddgrd oddgrd left review comments

@jonaro00 jonaro00 jonaro00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@supleed2 @jonaro00 @oddgrd