chore: update libsql dep #1694
Merged
chore: update libsql dep #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonaro00
approved these changes
Mar 20, 2024
oddgrd
reviewed
Mar 21, 2024
There was a problem hiding this comment.
Awesome, thank you @Jaco-Minnaar! It would be great to know what we need to change in the example as well, even if it's just bumping the version. Would you mind taking a look at that (https://github.com/shuttle-hq/shuttle-examples/tree/main/axum/turso)? A PR would be most welcome too, if you have time!
I'll take a quick look in the morning 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
I bumped the dependency on
libsqlin theshuttle-tursocreate tov0.3.1. I also refactored the code to replace the deprecatedDatabase::open_remoteandDatabase::openwith the newBuilderAPI.How has this been tested? (if applicable)
I ran the unit tests on the crate. If I need to do anything else, please let me know!