Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get project owners and only personal projects #1733

Merged
merged 7 commits into from
Apr 16, 2024

Conversation

chesedo
Copy link
Contributor

@chesedo chesedo commented Apr 11, 2024

Description of change

Add more details to projects to know who their owners are
Allow get the details of a single org
And allow only getting projects the user is the direct owner of

How has this been tested? (if applicable)

Added more tests and started the local stack

&self.proj_id,
&self.env_id,
Some(user_id),
Some("admin"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if they are not admin? Is this now a "get projects where I'm admin" method?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not quite. This is a "get projects where I have the admin role assigned method". So it won't return projects where the user is an "admin" because they are the admin of the org. I need this to be able to show users the projects they own which is not in some org.

@chesedo chesedo merged commit 13b334f into main Apr 16, 2024
30 of 32 checks passed
@chesedo chesedo deleted the refactor/extra_permit_endpoints branch April 16, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants