-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: merge shuttle-ecs-common to main #1753
Merged
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
f60106c
common: add control backend type
iulianbarbu 222b613
backends: reinstate http otel exporter
iulianbarbu 01b69a2
Merge remote-tracking branch 'upstream/main' into feat/shuttle-ecs-co…
oddgrd e40002b
feat: merge runtime updates in main ecs branch (#1709)
oddgrd 45e5d4e
feat: add resource request struct to backends (#1718)
oddgrd f732be0
Merge branch 'main' into feat/shuttle-ecs-common
jonaro00 72839f0
feat(cargo-shuttle): beta flag, remove project list pagination logic …
jonaro00 d09d803
feat: add models and header for new ecs provisioner (#1730)
oddgrd 2286c04
fix: runtime panic (#1735)
oddgrd cd7b71c
fix(cargo-shuttle): deploy http method
jonaro00 d3f6c6b
cargo-shuttle: update deploy cmd for beta platform (#1734)
iulianbarbu ae3c5b0
feat: add services client constructor for default headers (#1737)
oddgrd 81ecaae
feat(cargo-shuttle): beta deploy zip file, package name (#1742)
jonaro00 6231811
cargo-shuttle: added beta deployment status (#1740)
iulianbarbu 8767db4
Add log streaming in beta platform (#1743)
Kazy 82876bd
feat(cargo-shuttle beta): enable resource list (#1744)
oddgrd a44d095
cargo-shuttle: added beta deployment list (#1741)
iulianbarbu fe9f49c
feat(c-s beta): enable resource delete (#1745)
oddgrd b84ea8f
feat: support secrets on beta platform (#1748)
oddgrd 90bd111
feat(common): add building EcsState (#1752)
Kazy ceed492
Merge remote-tracking branch 'upstream/main' into feat/shuttle-ecs-co…
jonaro00 f1f4b4e
feat(cargo-shuttle): nits
jonaro00 b52786b
fix(cargo-shuttle): skip org project listing on beta
jonaro00 85a8d54
fix(backends): switch to http otel collector for compatibility with beta
jonaro00 3fc73ea
fix(runtime): make compatible with alpha & beta
jonaro00 a45addb
fix: make services compatible with beta runtime
jonaro00 a0e1bf1
Merge remote-tracking branch 'upstream/main' into feat/shuttle-ecs-co…
jonaro00 3757bfe
feat(runtime): version endpoint for runner version check
jonaro00 cd2c7a8
fix: review comments on ecs-common
jonaro00 95c155b
nit: update timeout comment
jonaro00 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
use serde::{Deserialize, Serialize}; | ||
|
||
/// Used by the runner service to send requests to control plane, where the requested resources | ||
/// will be provisioned. | ||
#[derive(Serialize, Deserialize)] | ||
pub struct ResourceRequest { | ||
/// The resource input returned from the runtime::load call. | ||
pub resources: Vec<Vec<u8>>, | ||
} | ||
|
||
/// Used to request the provisioning or deletion of a shared DB from the provisioner service. | ||
#[derive(Deserialize, Serialize)] | ||
pub struct SharedDbRequest { | ||
pub db_name: String, | ||
pub role_name: String, | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we making this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making it compatible with an ALB on beta platform IIRC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I had some trouble making gRPC work in front of the load balancer. I can try again though, I'll let you know how it goes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep can confirm, it's a PITA. We have an ALB in front of OTEL, which requires an HTTPS listener when targeting a gRPC target group. The issue is that to have an HTTPS listener, you need to have a valid ACM certificate attached to it, and to get a valid ACM certificate, you need to be able to verify it, which isn't possible for internal facing address.
I think we might be able to use ACM PCA (Private Certificate Authority), but that's not my priority right now.