Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: recursive permissionsdal impl #1785

Merged
merged 1 commit into from
May 24, 2024
Merged

fix: recursive permissionsdal impl #1785

merged 1 commit into from
May 24, 2024

Conversation

oddgrd
Copy link
Contributor

@oddgrd oddgrd commented May 24, 2024

Description of change

The impl added in #1784 was recursive, this changes it to call the methods on a reference to the inner value instead.

How has this been tested? (if applicable)

Deploying test stack with this change.

Copy link
Member

@jonaro00 jonaro00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has to work!!!! 💯 🥵

Copy link
Contributor

@chesedo chesedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙈

@oddgrd oddgrd merged commit 7d1c9db into main May 24, 2024
29 of 32 checks passed
@oddgrd oddgrd deleted the fix/recursive-permit-impl branch May 24, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants