Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add diesel-async support for shuttle-aws-rds #1808

Merged
merged 3 commits into from
Jul 24, 2024

Conversation

edgerunnergit
Copy link
Contributor

@edgerunnergit edgerunnergit commented Jun 16, 2024

Description of change

The following commits bring support to output diesel-async resources from all of the following databases:

  • #[shuttle_aws_rds::Postgres]
  • #[shuttle_aws_rds::MariaDB]
  • #[shuttle_aws_rds::MySql]

closely following the changes made in #1664

It closes: #1692

How has this been tested? (if applicable)

I have a local project for PoC which I can upload to github if needed.

@edgerunnergit edgerunnergit changed the title [Feature]: Add async-diesel to shuttle-aws-rds [Feature]: Add diesel-async to shuttle-aws-rds Jun 16, 2024
@edgerunnergit edgerunnergit changed the title [Feature]: Add diesel-async to shuttle-aws-rds feat: Add diesel-async support for shuttle-aws-rds Jun 16, 2024
Copy link
Member

@jonaro00 jonaro00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delayed review. Thanks for the contribution!

@jonaro00 jonaro00 merged commit 80892d3 into shuttle-hq:main Jul 24, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Add async-diesel to shuttle-aws-rds
2 participants